Code review comment for lp:~bac/launchpad/bug-490518-link-suggestion

= Summary =

The source package page needs a portlet to display upstream information if known -or-
allow the user to set it if not known.

== Proposed fix ==

A portlet is created that creates a widget of likely Launchpad projects the user can
pick from to set the upstream for the source package. A link to go to the existing
package editing form is also provided.

== Pre-implementation notes ==

The work is based on the design proposed by Curtis at
https://dev.launchpad.net/Registry/UbuntuLinkUpstream. He and I had discussions
before and during the implementation.

== Implementation details ==

Pretty straightforward: create the portlet and DTRT.

== Tests ==

bin/test -vvt sourcepackage-views.txt

== Demo and Q/A ==

In launchpad.dev, remove the association for evolution to hoary and then view:
https://launchpad.dev/ubuntu/hoary/+source/evolution

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/configure.zcml
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/registry/templates/sourcepackage-index.pt
  lib/lp/registry/browser/tests/sourcepackage-views.txt
  lib/lp/registry/templates/sourcepackage-portlet-associations.pt

== Pylint notices ==

lib/lp/registry/browser/sourcepackage.py
    28: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)