Code review comment for lp:~bac/launchpad/bug-491320

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

The construction of a textarea for a comment field was causing the pre-populated
values to have annoying newlines and spaces.

== Proposed fix ==

Use tal:content to set the values of <textarea> to avoid the problem.

== Pre-implementation notes ==

None

== Implementation details ==

As above.

== Tests ==

bin/test -t xx-team-membership.txt

== Demo and Q/A ==

Visit https://launchpad.dev/~hwdb-team/+member/bac, toggle one of the values and set
a comment. Return to the URL and ensure the comments is not marred by unsightly
whitespace.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/stories/team/xx-team-membership.txt
  lib/lp/registry/templates/teammembership-index.pt

--
Brad Crittenden
<email address hidden>

« Back to merge proposal