Code review comment for lp:~bac/launchpad/bug-496701-mimetypes

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

The initialization added to lib/site.py to modify the mimetypes standard library is
not functioning as planned. Moving the initialization to buildout.cfg, as Gary
initially suggested, does work.

== Proposed fix ==

Move init calls to the [scripts] section of buildout.cfg. A more standard place will
be provided by the foundations team in the near future.

== Pre-implementation notes ==

Call with Gary.

== Implementation details ==

As above.

== Tests ==

Interactive tests to prove the intialization has worked.

== Demo and Q/A ==

Perform the QA for bug 490224 and ensure it now works.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  buildout.cfg
  lib/site.py

« Back to merge proposal