Code review comment for lp:~bac/launchpad/bug-643538-code

Revision history for this message
Guilherme Salgado (salgado) wrote :

This looks good but I'm not sure the portlets will work nice with real data. For instance, if you see https://code.edge.launchpad.net/launchpad, most branches have long names, which cause most of the horizontal space to be used. How will that look with the portlets?

Also, it looks a bit weird having the two different styles of links (the Register a branch one uses a bigger font and the icon is to its left while the others use a smaller font and have the icon to the right) on the portlet. And by the way, are we moving the action links that were once inlined back into portlets?

review: Needs Information (ui*)

« Back to merge proposal