Code review comment for lp:~bac/launchpad/bug-643538-code

Revision history for this message
Curtis Hovey (sinzui) wrote :

The code looks fine. You fixed the sprite and comprehension issues I pointed out in the paste.

I was disappointed by the story additions, the stories did not really tell a story. I was also concerned that the /applets is owned by Foo Bar, so the test for an story about an owner was performed by an admin :(. We looked and did not see an intersection with the unittests in lp/code/browser/tests, so we decided to accept the changes. This branch is large and has a lot of value.

review: Approve (code)

« Back to merge proposal