Cool, +1.
[1]
+${ICING}/icon-sprites.positioning: bin/sprite-util + ${SHHH} bin/sprite-util create-image + +${ICING}/icon-sprites: bin/sprite-util ${SHHH} bin/sprite-util create-image
Although make seems to see that the command is identical and only runs it once, it might be clearer for future maintainers to express it instead as:
${ICING}/icon-sprites.positioning ${ICING}/icon-sprites: bin/sprite-util ${SHHH} bin/sprite-util create-image
[2]
+ def _sort(self, team_info, key='title'): + return sorted(team_info, cmp=lambda a,b: cmp(a[key], b[key]))
The cmp argument to sorted it deprecated and is gone in Python 3. This could be expressed instead as:
return sorted(team_info, key=lambda item: item[key])
or:
return sorted(team_info, key=itemgetter(key))
« Back to merge proposal
Cool, +1.
[1]
+${ICING} /icon-sprites. positioning: bin/sprite-util /icon-sprites: bin/sprite-util
+ ${SHHH} bin/sprite-util create-image
+
+${ICING}
${SHHH} bin/sprite-util create-image
Although make seems to see that the command is identical and only runs
it once, it might be clearer for future maintainers to express it
instead as:
${ICING} /icon-sprites. positioning ${ICING} /icon-sprites: bin/sprite-util
${SHHH} bin/sprite-util create-image
[2]
+ def _sort(self, team_info, key='title'):
+ return sorted(team_info, cmp=lambda a,b: cmp(a[key], b[key]))
The cmp argument to sorted it deprecated and is gone in Python 3. This
could be expressed instead as:
return sorted(team_info, key=lambda item: item[key])
or:
return sorted(team_info, key=itemgetter( key))