Code review comment for lp:~bac/launchpad/ec2_attached

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

Using 'ec2 land' the use of --headless is hard-coded. This branch adds
an '--attached' option for the very rare cases you don't want to use
headless.

== Proposed fix ==

Simply add the option to make --headless the default but optional.

== Pre-implementation notes ==

None.

== Implementation details ==

As above.

== Tests ==

None.

== Demo and Q/A ==

Run 'ec2 land --dry-run' with and without --attached

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/devscripts/ec2test/builtins.py

« Back to merge proposal