Code review comment for lp:~bac/launchpad/gmp

= Summary =

'ec2 land' is a great improvement in submitting branches via ec2 for landing as it
figures out all of the good parts and creates the PQM submit message. The original
version, however, requires the URL to the merge proposal as an argument. There is no
reason for requiring the MP as it can be found by using the public branch or push
location.

== Proposed fix ==

Make the merge proposal optional and if there is exactly one merge proposal for the
branch use it.

With this fix, if a developer is sitting in a branch that has an approved MP, she can
 send it off for test and landing by just doing:

% ec2 land

Presto bingo!

== Pre-implementation notes ==

Talked with Jonathan Lange and got good suggestions on how to make it more robust,
including falling back on the push location.

== Implementation details ==

None really.

== Tests ==

Erm...

== Demo and Q/A ==

Go to the directory for a branch that has a merge proposal in 'Approved' state and try:

% ec2 land --dry-run

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/devscripts/autoland.py
  lib/devscripts/ec2test/builtins.py

== Pylint notices ==

lib/devscripts/autoland.py
    124: [C0301] Line too long (79/78)

lib/devscripts/ec2test/builtins.py
    244: [C0301] Line too long (79/78)
    490: [C0301] Line too long (79/78)
    256: [W0102, cmd_test.run] Dangerous default value [] as argument
    428: [W0102, cmd_demo.run] Dangerous default value [] as argument
    500: [W0102, cmd_update_image.run] Dangerous default value [] as argument

I'll fix these before landing as appropriate.