Code review comment for lp:~bac/lazr.lifecycle/snapshot

Revision history for this message
Gary Poster (gary) wrote :

I like this.

As we discussed on IRC, I think this should be 1.1, not 1.0.1.

Please update the CHANGES file too.

We also agreed that adding a sugar function called doNotSnapshot would be nice, so that the field in the interface could look like this...

  ignore_me = doNotSnapshot(Attribute('ignored attribute'))

...rather than this.

  ignore_me = Attribute('ignored attribute')
  alsoProvides(ignore_me, IDoNotSnapshot)

The mechanism would stay the same: it's just sugar.

Thank you!

Gary

review: Approve (code)

« Back to merge proposal