Code review comment for lp:~barry/computer-janitor/ppa

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks, this looks fine.

Please note a minor gotcha:

+ #message = _('Are you sure you want to clean your system?')
+ message = _('Are you sure you want to clean up?')

A comment right above a gettext invocation is usually considered a translator comment, and will appear in .po files and Rosetta when translating. That might look a little confusing here, but I don't think it's a big deal.

(You might move the future string below it, though)

« Back to merge proposal