Code review comment for lp:~barry/gwibber/bug-990145

On Fri, 2012-05-11 at 16:52 -0700, Barry Warsaw wrote:
> On May 11, 2012, at 11:42 PM, Ken VanDine wrote:
>
> >Review: Needs Fixing
> >
> >twitter and facebook confirmed to work, however I tested with identica and
> >status.net and they aren't using a UTC time and give the same ValueError.
> >Here is an example time string:
> >
> >Wed Mar 21 02:30:31 -0400 2012
>
> Madness!
>
> What does Gwibber expect us to do with non-UTC timezones? Just dropping the
> tz doesn't seem right. OTOH, we have to convert them to naive datetimes. So
> I'm guessing we parse them into non-UTC tz-aware datetimes, then convert them
> to UTC, then make them tz-naive. Does that sound right?

Yeah, I think that is the only thing we can do. Sure wish they were
consistent :(

Thanks!

>
> >There is also a typo in the flickr plugin:
> >- timetup = datetime.utcfromtimestap(int(t)).timetuple()
> >+ timetup = datetime.utcfromtimestamp(int(t)).timetuple()
> >
> >The good news is that will be the last of the supported plugins, so once
> >identica and statusnet are working this is good to go!
>
> Yay! :)
>
> Cheers,
> -Barry
>

--
Ken VanDine
Ubuntu Desktop Integration Engineer
Canonical, Ltd.