Code review comment for lp:~barry/lazr.config/megamerge

On Jan 05, 2009, at 05:17 PM, Curtis Hovey wrote:

>Review: Approve code
>Hi Barry.
>
>Thanks for adding this goodness to lazr.config. I noticed that the spacing between headers in README.txt is inconsistent. I think we want two blank lines between before each heading. You can land the branch after you normalise the spacing.

Thanks for the review Curtis. I've normalized the spacing before headings,
and also done a whitespace cleanup. Here's the incremental:

=== modified file 'src/lazr/config/README.txt'
--- src/lazr/config/README.txt 2008-12-31 14:44:38 +0000
+++ src/lazr/config/README.txt 2009-01-05 19:29:12 +0000
@@ -9,6 +9,7 @@
 The config file supports inheritance to minimize duplication of
 information across files. The format supports schema validation.

+
 ============
 ConfigSchema
 ============
@@ -168,7 +169,7 @@
     >>> missing = object()
     >>> schema.getByCategory('non-section', missing) is missing
     True
-
+

 =============
 SchemaSection
@@ -255,6 +256,7 @@
     key2 : changed
     key3 : unique

+
 =======================
 ConfigSchema validation
 =======================
@@ -312,6 +314,7 @@
       ...
     InvalidSectionNameError: [$category.name_part.optional] ...

+
 =============
 IConfigLoader
 =============
@@ -361,6 +364,7 @@

 The bad_config example will be used for validation tests.

+
 ======
 Config
 ======
@@ -540,6 +544,7 @@
     >>> config.getByCategory('non-section', missing) is missing
     True

+
 =======
 Section
 =======
@@ -639,6 +644,7 @@
      ...
     AttributeError: Config options cannot be set directly.

+
 ==================
 Validating configs
 ==================
@@ -667,6 +673,7 @@
     UnknownKeyError: The meta section does not have a metakey key.
     UnknownSectionError: base.conf does not have a unknown-section section.

+
 ===============
 Config overlays
 ===============
@@ -715,6 +722,7 @@
     ... print config_data.name
     base.conf

+
 push()
 ======

@@ -853,7 +861,7 @@
     bar.soup cougar
     bar.two dolphin

- >>> master_conf.push('overlord', """
+ >>> master_conf.push('overlord', """
     ... [bar.three]
     ... baz: emu
     ... """)
@@ -958,6 +966,7 @@
     >>> print config.extends
     None

+
 ===============================
 Attribute access to config data
 ===============================
@@ -1015,6 +1024,7 @@
       ...
     AttributeError: No section key named non_key.

+
 ====================
 Implicit data typing
 ====================
@@ -1159,6 +1169,7 @@
     >>> implicit_config['section_33'].key2
     'multiline value 1\nmultiline value 2'

+
 =======================
 Type conversion helpers
 =======================
@@ -1167,6 +1178,7 @@
 functions have to be imported and called explicitly on the configuration
 variable values.

+
 Booleans
 ========

@@ -1271,6 +1283,7 @@
     ...
     ValueError: invalid literal for int...foo...

+
 User and group
 ==============

@@ -1307,6 +1320,7 @@
     >>> group == grp.getgrgid(os.getgid()).gr_name
     True

+
 Time intervals
 ==============

@@ -1383,6 +1397,7 @@
     ...
     ValueError

+
 Log levels
 ==========