Code review comment for lp:~barry/ubuntu/lucid/distribute/sync-to-sid

Revision history for this message
Scott Kitterman (kitterman) wrote :

The diff looks good. For debian/changelog, we want an entry that looks something like:

  * Merge from Debian Unstable. Remaining Ubuntu changes:
    - Document each item of the diff here so it's clear where we
      diverge from Debian and why
    - Adjust debian/rules to only build modules and extensions for Python 2.6
      instead of Python 2.4/2.5 (or whatever needs describing)

If I didn't know you really wanted to learn this stuff, I'd probably just fix it an upload, but since you do ....

review: Needs Fixing

« Back to merge proposal