Code review comment for lp:~bdrung/xiphos/lintian-clean

Benjamin Drung wrote:

> I get following report from lintian -iIE --pedantic (version 2.2.14,
> build on jaunty):
> P: xiphos: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL
> W: xiphos: binary-or-shlib-defines-rpath ./usr/bin/xiphos /usr/lib
> W: xiphos: binary-or-shlib-defines-rpath ./usr/bin/xiphos /lib
> P: xiphos-data: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL
> P: gnomesword: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL
>
> My changes are not huge. The problem is the 2.3 MiB big auto-generated
> patch. Attached the diff with this patch trimmed down. Then the changes
> are only 60 lines long.

OK, thanks. That helps :) I think it might be simpler to just
build-depend on chrpath and run it

  chrpath -d $(CURDIR)/usr/bin/xiphos

(or something like that) in debian/rules at the appropriate point,
rather than carry such a big patch around?

That is how I handled (removed) the rpath warnings in the sword package,
which Dmitri and I created together and which xiphos depends on.

Then, longer term, we can (hopefully) persuade "upstream" to put newer
autoconf-generated files in their release tarballs.

I think that it is easier to deal with (easier to read, understand and
review) a line or two more in debian/rules, instead of adding a 2+ MByte
patch :)

Do you know if it is common to have such large patches just to overcome
lintian warnings like this?

Jonathan