Code review comment for lp:~benji/launchpad/better-HTML-generation

Revision history for this message
Brad Crittenden (bac) wrote :

This is a vast improvement over our original way of creating the html content for the overlay. Thanks for cleaning it all up.

As we discussed on IRC I am a little concerned that there are still large sections of string concatenation to create the recipient picker and overlay container. You pointed out it is all constant string values so it shouldn't present a problem. In the future we can always break those sections down if it proves to be needed.

review: Approve (code)

« Back to merge proposal