Code review comment for lp:~benji/launchpad/bug-597324

test_redirect_logic looks like it has 3 or 4 separate tests in it - please split that out for readability.

Your fakes could do with a docstring each to describe their intent, and lastly your static methods are a little weird; if they are not stateful, please consider functions; if they are tightly coupled, but are called from instances, please use normal methods.

With these changes it can land without another review.

Thanks,
Rob