Code review comment for lp:~benji/launchpad/bug-612754-2

Revision history for this message
Benji York (benji) wrote :

On Wed, Oct 6, 2010 at 6:54 PM, Edwin Grubbs <email address hidden> wrote:
> Review: Needs Fixing code
> Hi Benji,
>
> I think the regex and the test need some work to handle trailing whitespace
> on any line.

That's odd. I had made a change along those lines before even
submitting the branch for review but the diff on the MP doesn't reflect
the change.

Darn! I forgot to push after commit. The more appropriate regex and
test should be visible after the diff updates.
--
Benji York

« Back to merge proposal