Launchpad itself

Code review comment for lp:~benji/launchpad/bug-669701

  1. bug-669701
  2. Merge into devel
Revision history for this message
Martin Pool (mbp) wrote :

The text diff seems nice. It might be a bit nicer if you did a diff against the value read back by getAllRulesAsText(), which will avoid spurious diffs due to text changes that the database doesn't care about.

The NameError you fixed in passing was https://bugs.launchpad.net/launchpad/+bug/651852 -- well done!

« Back to merge proposal