Code review comment for lp:~benji/launchpad/bug-753152

Revision history for this message
Gary Poster (gary) wrote :

This is a good fix. As we discussed, it wasn't actually what I intended to bring up in bug 753152, but this direct subscription muting is a parallel problem, and worthy of explaining. The JS lint and innerHTML changes look nice too.

Approved, with the following changes:

 - Move lib/lp/bugs/help/structural-subscription-mute.html to lib/lp/bugs/help/subscription-mute.html or similar.
 - fix typo "abotu"
 - land as incremental fix for the bug (or new bug as you wish) and then make another branch to fix the structural subscription version of the bug.

Thank you,

Gary

review: Approve

« Back to merge proposal