Code review comment for lp:~benji/launchpadlib/delayed-keyring-import

Revision history for this message
Henning Eggers (henninge) wrote :

The changes look good, thank you. I just wonder how the definition of "credential_store_factory" relates to this. Is that supposed to be in here? Please have a look before you land this.

review: Approve (code)

« Back to merge proposal