Code review comment for lp:~benji/launchpadlib/delayed-keyring-import

Revision history for this message
Benji York (benji) wrote :

On Mon, Jan 10, 2011 at 12:51 PM, Henning Eggers
<email address hidden> wrote:
> Review: Approve code
> The changes look good, thank you. I just wonder how the definition of
> "credential_store_factory" relates to this. Is that supposed to be in here?
> Please have a look before you land this.

The credential_store_factory definition in question is for a class
that's used in tests. The credential_store_factory returns the place
where credentials should be stored, which for the tests in question is
on disk (as opposed to in the keyring).

Thanks for the review.
--
Benji York

« Back to merge proposal