Launchpad itself

Merge lp:~beuno/launchpad/margin-tweaks into lp:launchpad

  1. margin-tweaks
  2. Merge into devel
Proposed by Martin Albisetti
Status: Merged
Approved by: Martin Albisetti
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~beuno/launchpad/margin-tweaks
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~beuno/launchpad/margin-tweaks
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Approve
Review via email: mp+11689@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Albisetti (beuno) wrote :

This branch scratches a few minor itches:

- Removes the strong tag from the "Uses launchpad for" portlet, which just made the link black and not bold
- Makes breadcrumbs smaller and adds more margin
- Adds more margin between portlets and makes the separator line lighter

Revision history for this message
Martin Albisetti (beuno) wrote :

It also does something else, which is drop the green from the headings as they overlap with our "green links are ajax" pattern.

Revision history for this message
Eleanor Berger (intellectronica) wrote :

lovely

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
2--- lib/canonical/launchpad/icing/style-3-0.css 2009-09-12 01:57:22 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css 2009-09-14 10:13:55 +0000
4@@ -207,7 +207,7 @@
5 }
6 .footer {
7 clear: both;
8- margin-top: 2em;
9+ margin-top: 4em;
10 padding-top: 0.5em;
11 }
12 .footer .lp-arcana {
13@@ -230,8 +230,8 @@
14 }
15 .portlet, .aside {
16 clear: both;
17- border-top: 1px solid #d6d6d6;
18- padding: 0.5em 0;
19+ border-top: 1px solid #EBEBEB;
20+ padding: 1em 0;
21 }
22 .top-portlet {
23 padding: 0 0 0.5em 0;
24
25=== modified file 'lib/canonical/launchpad/icing/style.css'
26--- lib/canonical/launchpad/icing/style.css 2009-09-10 12:59:56 +0000
27+++ lib/canonical/launchpad/icing/style.css 2009-09-14 09:40:39 +0000
28@@ -308,7 +308,6 @@
29 margin: 0 0 0.5em;
30 /* Content headings are highlighted using a different color (the color is
31 overriden per-application in subsequent rules) instead of bold text. */
32- color: #83ad23;
33 font-weight: normal;
34 }
35 h1 {font-size: 2em;}
36@@ -729,7 +728,8 @@
37 margin-left: 0;
38 list-style-type: none;
39 clear: both;
40- margin-bottom: 0.5em;
41+ margin-bottom: 1em;
42+ font-size: 80%;
43 }
44 ol.breadcrumbs li {
45 display:inline;
46
47=== modified file 'lib/lp/registry/browser/distribution.py'
48--- lib/lp/registry/browser/distribution.py 2009-09-10 18:53:09 +0000
49+++ lib/lp/registry/browser/distribution.py 2009-09-14 09:39:41 +0000
50@@ -94,7 +94,7 @@
51 def uses_launchpad_for(self):
52 """Return a string of LP apps (comma-separated) this distro uses."""
53 uses = []
54- href_template = """<a href="%s"><strong>%s</strong></a>"""
55+ href_template = """<a href="%s">%s</a>"""
56 if self.context.official_answers:
57 url = canonical_url(self.context, rootsite='answers')
58 uses.append(href_template % (url, 'Answers'))