Launchpad itself

Merge lp:~beuno/launchpad/margin-tweaks into lp:launchpad

  1. margin-tweaks
  2. Merge into devel
Proposed by Martin Albisetti
Status: Merged
Approved by: Martin Albisetti
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~beuno/launchpad/margin-tweaks
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~beuno/launchpad/margin-tweaks
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Approve
Review via email: mp+11689@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Albisetti (beuno) wrote :

This branch scratches a few minor itches:

- Removes the strong tag from the "Uses launchpad for" portlet, which just made the link black and not bold
- Makes breadcrumbs smaller and adds more margin
- Adds more margin between portlets and makes the separator line lighter

Revision history for this message
Martin Albisetti (beuno) wrote :

It also does something else, which is drop the green from the headings as they overlap with our "green links are ajax" pattern.

Revision history for this message
Eleanor Berger (intellectronica) wrote :

lovely

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css 2009-09-12 01:57:22 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css 2009-09-14 10:13:55 +0000
@@ -207,7 +207,7 @@
207 }207 }
208.footer {208.footer {
209 clear: both;209 clear: both;
210 margin-top: 2em;210 margin-top: 4em;
211 padding-top: 0.5em;211 padding-top: 0.5em;
212 }212 }
213.footer .lp-arcana {213.footer .lp-arcana {
@@ -230,8 +230,8 @@
230 }230 }
231.portlet, .aside {231.portlet, .aside {
232 clear: both;232 clear: both;
233 border-top: 1px solid #d6d6d6;233 border-top: 1px solid #EBEBEB;
234 padding: 0.5em 0;234 padding: 1em 0;
235 }235 }
236.top-portlet {236.top-portlet {
237 padding: 0 0 0.5em 0;237 padding: 0 0 0.5em 0;
238238
=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css 2009-09-10 12:59:56 +0000
+++ lib/canonical/launchpad/icing/style.css 2009-09-14 09:40:39 +0000
@@ -308,7 +308,6 @@
308 margin: 0 0 0.5em;308 margin: 0 0 0.5em;
309 /* Content headings are highlighted using a different color (the color is309 /* Content headings are highlighted using a different color (the color is
310 overriden per-application in subsequent rules) instead of bold text. */310 overriden per-application in subsequent rules) instead of bold text. */
311 color: #83ad23;
312 font-weight: normal;311 font-weight: normal;
313}312}
314h1 {font-size: 2em;}313h1 {font-size: 2em;}
@@ -729,7 +728,8 @@
729 margin-left: 0;728 margin-left: 0;
730 list-style-type: none;729 list-style-type: none;
731 clear: both;730 clear: both;
732 margin-bottom: 0.5em;731 margin-bottom: 1em;
732 font-size: 80%;
733}733}
734ol.breadcrumbs li {734ol.breadcrumbs li {
735 display:inline;735 display:inline;
736736
=== modified file 'lib/lp/registry/browser/distribution.py'
--- lib/lp/registry/browser/distribution.py 2009-09-10 18:53:09 +0000
+++ lib/lp/registry/browser/distribution.py 2009-09-14 09:39:41 +0000
@@ -94,7 +94,7 @@
94 def uses_launchpad_for(self):94 def uses_launchpad_for(self):
95 """Return a string of LP apps (comma-separated) this distro uses."""95 """Return a string of LP apps (comma-separated) this distro uses."""
96 uses = []96 uses = []
97 href_template = """<a href="%s"><strong>%s</strong></a>"""97 href_template = """<a href="%s">%s</a>"""
98 if self.context.official_answers:98 if self.context.official_answers:
99 url = canonical_url(self.context, rootsite='answers')99 url = canonical_url(self.context, rootsite='answers')
100 uses.append(href_template % (url, 'Answers'))100 uses.append(href_template % (url, 'Answers'))