Code review comment for lp:~beuno/loggerhead/bzr-search_integration
Revision history for this message
| Michael Hudson-Doyle (mwhudson) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
So, sorry for taking such a very long time to get to this.
I have a few comments, mostly cosmetic:
The change in size/layout of the suggestions div when it goes from "Loading..." to the suggestions is a bit disconcerting.
The padding on the suggestions box seems excessive -- what I think would be ideal is the left edge of the suggestions lined up with the left edge of the text in the box you are typing in.
Things get a little silly when the list of suggestions is very long -- the suggestions div is way way longer than the page.
Shouldn't the selection box disappear when the search field is un-focused?
Is it easily possible to allow the use of the keyboard for selecting suggestions?
It's pretty hard to see why the results that are returned are returned and also the order is a bit incomprehensible.
Some of these (particularly the last two) can be done after the code has landed. But let's have a talk about the various points before that happens.
The code is all fine at least :)