Code review comment for lp:~bjornt/launchpad/bug-462502

Revision history for this message
Björn Tillenius (bjornt) wrote :

Unbreak Javascript when devmode is turned off.

When lazr-js was buildoutified, the order of the files passed in to the JS combinator changed. This had the effect that some code stopped working, since it depended on definitions being above it.

This branch changes the order of the files, so that launchpad.js is now identical to the one in r9785. I removed EXTRA_JS_FILES variable, since I couldn't find a way of inserting the output of yui-deps.py into it. Simply putting EXTRA_JS_FILES as the last argument didn't work either, the JS was still broken.

« Back to merge proposal