Merge lp:~bjornt/launchpad/choiceedit-click-handler into lp:launchpad/db-devel
Proposed by
Björn Tillenius
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~bjornt/launchpad/choiceedit-click-handler | ||||
Merge into: | lp:launchpad/db-devel | ||||
Diff against target: |
14 lines (+2/-2) 1 file modified
lib/canonical/launchpad/javascript/bugs/bugtask-index.js (+2/-2) |
||||
To merge this branch: | bzr merge lp:~bjornt/launchpad/choiceedit-click-handler | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guilherme Salgado (community) | release-critical | Approve | |
Graham Binns (community) | js | Approve | |
Review via email: mp+15484@code.launchpad.net |
To post a comment you must log in.
Fix "Target to milestone" on the bug page to work inline again.
A change in lazr-js fixed some issues with the ChoiceEdit, making it
work in Opera. However, when LP was changed to use this newer lazr-js
version, the code that set up the "Target to milestone" link wasn't
updated, causing the code to break, since it tried calling and old
method that doesn't exist anymore.
I would normally write a Windmill test for this (which would have
caught this error earlier), but Tom is already writing tests for the
bug task table (bug 488142).
-- /launchpad. net/~bjornt
Björn Tillenius | https:/