Code review comment for lp:~bjornt/launchpad/choiceedit-click-handler

Revision history for this message
Björn Tillenius (bjornt) wrote :

Fix "Target to milestone" on the bug page to work inline again.

A change in lazr-js fixed some issues with the ChoiceEdit, making it
work in Opera. However, when LP was changed to use this newer lazr-js
version, the code that set up the "Target to milestone" link wasn't
updated, causing the code to break, since it tried calling and old
method that doesn't exist anymore.

I would normally write a Windmill test for this (which would have
caught this error earlier), but Tom is already writing tests for the
bug task table (bug 488142).

--
Björn Tillenius | https://launchpad.net/~bjornt

« Back to merge proposal