Launchpad itself

Merge lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags into lp:launchpad

  1. bug-supervisor-modify-distro-official-tags
  2. Merge into devel
Proposed by Brian Murray
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: 11768
Proposed branch: lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags
Merge into: lp:launchpad
Diff against target: 57 lines (+16/-2)
3 files modified
lib/lp/bugs/doc/official-bug-tags.txt (+1/-1)
lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt (+11/-0)
lib/lp/registry/configure.zcml (+4/-1)
To merge this branch: bzr merge lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+38743@code.launchpad.net

Commit message

Allow bug supervisor to set official_bug_tags for a distribution.

Description of the change

This is a follow up to https://code.edge.launchpad.net/~brian-murray/launchpad/modify-official-bug-tags-permissions/+merge/37758. I missed moving the set_attribute for official_bug_tags from launchpad.Edit to launchpad.BugSupervisor for a distribution. It works fine for products though.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/doc/official-bug-tags.txt'
2--- lib/lp/bugs/doc/official-bug-tags.txt 2010-10-09 16:36:22 +0000
3+++ lib/lp/bugs/doc/official-bug-tags.txt 2010-10-20 18:26:12 +0000
4@@ -169,7 +169,7 @@
5 >>> ubuntu.official_bug_tags = [u'foo', u'bar']
6 Traceback (most recent call last):
7 ...
8- Unauthorized: (<Distribution 'Ubuntu' (ubuntu)>, 'official_bug_tags', 'launchpad.Edit')
9+ Unauthorized: (<Distribution 'Ubuntu' (ubuntu)>, 'official_bug_tags', 'launchpad.BugSupervisor')
10
11 The same is available for products.
12
13
14=== modified file 'lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt'
15--- lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2010-10-15 14:26:57 +0000
16+++ lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2010-10-20 18:26:12 +0000
17@@ -71,6 +71,17 @@
18 >>> print bug_super_browser.url
19 http://bugs.launchpad.dev/youbuntu/+manage-official-tags
20
21+The bug supervisor can also set the tags for the product.
22+
23+ >>> bug_super_browser.getControl('Official Bug Tags').value = 'foo bar'
24+ >>> bug_super_browser.getControl('Save').click()
25+ >>> print bug_super_browser.url
26+ http://bugs.launchpad.dev/youbuntu
27+ >>> bug_super_browser.open(
28+ ... 'http://bugs.launchpad.dev/youbuntu/+manage-official-tags')
29+ >>> print bug_super_browser.getControl('Official Bug Tags').value
30+ bar foo
31+
32 == Official Tags on Bug Pages ==
33
34 Official tags are displayed using a different style from unofficial ones.
35
36=== modified file 'lib/lp/registry/configure.zcml'
37--- lib/lp/registry/configure.zcml 2010-10-14 21:47:33 +0000
38+++ lib/lp/registry/configure.zcml 2010-10-20 18:26:12 +0000
39@@ -1475,7 +1475,6 @@
40 mugshot
41 official_answers
42 official_blueprints
43- official_bug_tags
44 official_malone
45 official_rosetta
46 owner
47@@ -1483,6 +1482,10 @@
48 summary
49 title"/>
50 <require
51+ permission="launchpad.BugSupervisor"
52+ set_attributes="
53+ official_bug_tags"/>
54+ <require
55 permission="launchpad.TranslationsAdmin"
56 set_attributes="
57 language_pack_admin