Launchpad itself

Merge lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags into lp:launchpad

  1. bug-supervisor-modify-distro-official-tags
  2. Merge into devel
Proposed by Brian Murray
Status: Merged
Approved by: Graham Binns
Approved revision: no longer in the source branch.
Merged at revision: 11768
Proposed branch: lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags
Merge into: lp:launchpad
Diff against target: 57 lines (+16/-2)
3 files modified
lib/lp/bugs/doc/official-bug-tags.txt (+1/-1)
lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt (+11/-0)
lib/lp/registry/configure.zcml (+4/-1)
To merge this branch: bzr merge lp:~brian-murray/launchpad/bug-supervisor-modify-distro-official-tags
Reviewer Review Type Date Requested Status
Graham Binns (community) code Approve
Review via email: mp+38743@code.launchpad.net

Commit message

Allow bug supervisor to set official_bug_tags for a distribution.

Description of the change

This is a follow up to https://code.edge.launchpad.net/~brian-murray/launchpad/modify-official-bug-tags-permissions/+merge/37758. I missed moving the set_attribute for official_bug_tags from launchpad.Edit to launchpad.BugSupervisor for a distribution. It works fine for products though.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/doc/official-bug-tags.txt'
--- lib/lp/bugs/doc/official-bug-tags.txt 2010-10-09 16:36:22 +0000
+++ lib/lp/bugs/doc/official-bug-tags.txt 2010-10-20 18:26:12 +0000
@@ -169,7 +169,7 @@
169 >>> ubuntu.official_bug_tags = [u'foo', u'bar']169 >>> ubuntu.official_bug_tags = [u'foo', u'bar']
170 Traceback (most recent call last):170 Traceback (most recent call last):
171 ...171 ...
172 Unauthorized: (<Distribution 'Ubuntu' (ubuntu)>, 'official_bug_tags', 'launchpad.Edit')172 Unauthorized: (<Distribution 'Ubuntu' (ubuntu)>, 'official_bug_tags', 'launchpad.BugSupervisor')
173173
174The same is available for products.174The same is available for products.
175175
176176
=== modified file 'lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt'
--- lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2010-10-15 14:26:57 +0000
+++ lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2010-10-20 18:26:12 +0000
@@ -71,6 +71,17 @@
71 >>> print bug_super_browser.url71 >>> print bug_super_browser.url
72 http://bugs.launchpad.dev/youbuntu/+manage-official-tags72 http://bugs.launchpad.dev/youbuntu/+manage-official-tags
7373
74The bug supervisor can also set the tags for the product.
75
76 >>> bug_super_browser.getControl('Official Bug Tags').value = 'foo bar'
77 >>> bug_super_browser.getControl('Save').click()
78 >>> print bug_super_browser.url
79 http://bugs.launchpad.dev/youbuntu
80 >>> bug_super_browser.open(
81 ... 'http://bugs.launchpad.dev/youbuntu/+manage-official-tags')
82 >>> print bug_super_browser.getControl('Official Bug Tags').value
83 bar foo
84
74== Official Tags on Bug Pages ==85== Official Tags on Bug Pages ==
7586
76Official tags are displayed using a different style from unofficial ones.87Official tags are displayed using a different style from unofficial ones.
7788
=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml 2010-10-14 21:47:33 +0000
+++ lib/lp/registry/configure.zcml 2010-10-20 18:26:12 +0000
@@ -1475,7 +1475,6 @@
1475 mugshot1475 mugshot
1476 official_answers1476 official_answers
1477 official_blueprints1477 official_blueprints
1478 official_bug_tags
1479 official_malone1478 official_malone
1480 official_rosetta1479 official_rosetta
1481 owner1480 owner
@@ -1483,6 +1482,10 @@
1483 summary1482 summary
1484 title"/>1483 title"/>
1485 <require1484 <require
1485 permission="launchpad.BugSupervisor"
1486 set_attributes="
1487 official_bug_tags"/>
1488 <require
1486 permission="launchpad.TranslationsAdmin"1489 permission="launchpad.TranslationsAdmin"
1487 set_attributes="1490 set_attributes="
1488 language_pack_admin1491 language_pack_admin