Code review comment for lp:~brian-murray/launchpad/bug-supervisor-permissions

Revision history for this message
Māris Fogels (mars) wrote :

This is a great change. The test helpers make the change very clean and readable. r=mars

One suggestion for readability: consider renaming self.target and setupTarget() to something like self.context and setupViewContext(). I had to open the base class docstring to understand what the 'target' created by setupTarget actually is.

Maris

review: Approve

« Back to merge proposal