Code review comment for lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Two small points: have you checked the query impact of this? It looks
like it will do a lot of queries, to me.
Separately, have you considered just having the list of 'can
unsubscribe' things include separate actions for each bug.
e.g.
subscribers
teamfoo [-]
teamfoo (via 1234) [-]
teambar (via 3456) [-]
This would keep the unsubscribe actions in the same place (a good
thing), not make showing the list of dupes more expensive ( a good
thing) and leave the dup list cacheable if we choose to) (a good
thing)