Code review comment for lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers

Revision history for this message
Robert Collins (lifeless) wrote :

The table formatted awkwardly.
Can you confirm:
(dup subs, devel, old proposal, current proposal)
(0, 24, 24, 25)
(1, 26, 27, 26)
(2, 28, 29, 28)
(3, 29, 32, 29)

This is certainly better. It appears to still scale with duplication
subscriptions which is a problem. (And the query count is still quite
large: for a portlet like this, 10-15 queries is what I'd expect).

I haven't reviewed the code yet, but on the sheer performance size,
these query counts (which are only a surrogate) are at least no-worse.

If you want to grab an OCR to review this your friday, please do :
don't block on me looking at the actual change - whomever reviews it
can advise on the tastefulness of your approach to the scaling issue.

« Back to merge proposal