Code review comment for lp:~brian-murray/launchpad/limited-subscriptions-page

Revision history for this message
Curtis Hovey (sinzui) wrote :

I am review r11483,

I am seeing some problems as Sample Person when I try to manage my subscriptions
    https://launchpad.dev/~name12/+subscriptions
 * I choose to remove the blackhole subscription. The link to edit it shows a radio button. I cannot unselected it. I can change it.
 * If The cancel link goes to the bug, not +subscriptions

Check my teams (as Sample Person)
    https://launchpad.dev/~hwdb-team/+subscriptions
 * I cannot unselect the radio button for the team. I can of course select myself to deselect the team, but I do not want to subscribe to the bug
 * Again the cancel link the bug, not +subscriptions

As anonymous when I see https://launchpad.dev/~hwdb-team/+subscriptions I read
    HWDB Team does not have any direct bug subscriptions.
^ that is great, I think the text for the bug listing table should make it clear I am seeing "direct bug subscriptions"

I think part of the problem here is that I am reading the story, but it is clearly not a story. A story is from a users perspective and explains his experience performing a task. There are not tasks completed in this story, and when I try to complete what I think Sample Person is doing, I fail. I will reply in about 30 minutes with a revised story I what I think the users' goals are.

review: Needs Fixing (ui)

« Back to merge proposal