Code review comment for lp:~brian-murray/launchpad/person-subscription-story

Revision history for this message
Leonard Richardson (leonardr) wrote :

You mention Webster in the text before creating that person. To avoid confusion, the first mention of Webster should be something like "We're going to create a person called Webster... Any user can see..."

You mention bug #16 in the test text but you never mention it as a code literal, so you can remove it from the text.

You still mention bug 17 as a code literal, as well as the subscriber id 243656. Can you do better?

In a big code branch I'd consider these changes on the level of "approve with changes". But since the point of this branch is to improve the test, I'm marking this 'needs fixing'

review: Needs Fixing

« Back to merge proposal