This code looks good, r=mars. I have a few comments about docstrings and the test suite:
• The constructor arguments to BugzillaRemoteComponentFinder should be documented. The parameter name "txn" does not provide enough information. The parameter object type should be documented at minimum.
• There is a grammar error in the comment on line 293, "need added"
• How long does it take to run your new test suite? We want to try and keep new tests under 2 seconds runtime.
Hi Bryce,
This code looks good, r=mars. I have a few comments about docstrings and the test suite:
• The constructor arguments to BugzillaRemoteC omponentFinder should be documented. The parameter name "txn" does not provide enough information. The parameter object type should be documented at minimum.
• There is a grammar error in the comment on line 293, "need added"
• How long does it take to run your new test suite? We want to try and keep new tests under 2 seconds runtime.
Maris