Code review comment for lp:~bryce/launchpad/lp-617691-retrieve

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks mars.

In looking closer, I don't actually use txn anywhere (I'd inherited it from the sf update script) so I've dropped it entirely.

Grammar error is fixed by restating the comment.

The test suite takes around 11 seconds to run. Most of that is due to it running the full cronjob. Disabling that test brings it down to 2.5 seconds.

There are two tests which parse a copy of the freedesktop.org bugzilla advanced search page, which contains a lengthy number of components. If I replace one of those and have it parse the (much smaller) Wine bugzilla advanced search page, it brings the test down to about 1.8 seconds.

« Back to merge proposal