Merge lp:~cando/zeitgeist-datasources/fix_chromium into lp:zeitgeist-datasources/0.8

Proposed by Stefano Candori
Status: Merged
Merge reported by: Michal Hruby
Merged at revision: not available
Proposed branch: lp:~cando/zeitgeist-datasources/fix_chromium
Merge into: lp:zeitgeist-datasources/0.8
Diff against target: 50 lines (+9/-4)
2 files modified
bzr/__init__.py (+6/-3)
chrome/zeitgeist.js (+3/-1)
To merge this branch: bzr merge lp:~cando/zeitgeist-datasources/fix_chromium
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+45599@code.launchpad.net

Description of the change

In this branch i've added a control on the browser name. Doing that we can put the right actor-name ( and so the right desktop-file) in the event.actor field.
Fx doing that GAJ shows web-events with the right Chromium icon.

To post a comment you must log in.
Revision history for this message
Stefano Candori (cando) wrote :

well...in this diff there is also the other bzr merge proposal....sorry

Revision history for this message
Michal Hruby (mhr3) wrote :

The Chromium fix is good, merging only that...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzr/__init__.py'
--- bzr/__init__.py 2010-11-01 16:32:39 +0000
+++ bzr/__init__.py 2011-01-08 11:09:00 +0000
@@ -17,7 +17,7 @@
17# You should have received a copy of the GNU Lesser General Public License17# You should have received a copy of the GNU Lesser General Public License
18# along with this program. If not, see <http://www.gnu.org/licenses/>.18# along with this program. If not, see <http://www.gnu.org/licenses/>.
1919
20"""Post-commit hook to submit the commit to Zeitgeist (http://www.zeitgeist-project.com)20"""Post-commit and post-pull hook to submit the commit to Zeitgeist (http://www.zeitgeist-project.com)
2121
22Requires bzr 0.15 or higher.22Requires bzr 0.15 or higher.
2323
@@ -63,8 +63,9 @@
63 _text += str(new_revno) + "\n"63 _text += str(new_revno) + "\n"
64 _text += revision.message.rstrip()64 _text += revision.message.rstrip()
6565
66 uri = master.base + "#revision=" + str(new_revno)
66 subject = Subject.new_for_values(67 subject = Subject.new_for_values(
67 uri=unicode(master.base),68 uri=unicode(uri),
68 interpretation=unicode(Interpretation.FOLDER),69 interpretation=unicode(Interpretation.FOLDER),
69 manifestation=unicode(Manifestation.FILE_DATA_OBJECT),70 manifestation=unicode(Manifestation.FILE_DATA_OBJECT),
70 text=unicode(_text),71 text=unicode(_text),
@@ -88,8 +89,10 @@
88 _text += (" to revision ")89 _text += (" to revision ")
89 _text += str(master.revno())+":\n"90 _text += str(master.revno())+":\n"
90 _text += revision.get_summary()91 _text += revision.get_summary()
92
93 uri = master.base + "#revision=" + str(master.revno())
91 subject = Subject.new_for_values(94 subject = Subject.new_for_values(
92 uri=unicode(master.base),95 uri=unicode(uri),
93 interpretation=unicode(Interpretation.FOLDER),96 interpretation=unicode(Interpretation.FOLDER),
94 manifestation=unicode(Manifestation.FILE_DATA_OBJECT),97 manifestation=unicode(Manifestation.FILE_DATA_OBJECT),
95 text=unicode(_text),98 text=unicode(_text),
9699
=== modified file 'chrome/zeitgeist.js'
--- chrome/zeitgeist.js 2010-11-25 16:26:14 +0000
+++ chrome/zeitgeist.js 2011-01-08 11:09:00 +0000
@@ -46,7 +46,9 @@
46 sendAccessEvent(request);46 sendAccessEvent(request);
47}47}
4848
49plugin.setActor("application://google-chrome.desktop");49var is_chromium = /chromium/.test( navigator.userAgent.toLowerCase() );
50if (!is_chromium) plugin.setActor("application://google-chrome.desktop");
51else plugin.setActor("application://chromium-browser.desktop");
5052
51//chrome.extension.onConnect.addListener (onExtensionConnect);53//chrome.extension.onConnect.addListener (onExtensionConnect);
52chrome.extension.onRequest.addListener (onExtensionRequest);54chrome.extension.onRequest.addListener (onExtensionRequest);

Subscribers

People subscribed via source and target branches