Code review comment for lp:~chrisccoulson/libdbusmenu/lp1011073

Revision history for this message
Ted Gould (ted) wrote :

"&=" is not an appropriate way to deal with integers, it's premature
optimization. It's find to use something like:

if (menuitem_next_id >= G_MAXINT) {
�* DO STUFF *�
}

That makes it much easier for the person fixing bugs in this code in the
future. It documents what you're thinking.

  review -1

review: Disapprove

« Back to merge proposal