britney

Merge lp:~cjwatson/britney/output-prefix into lp:~ubuntu-release/britney/britney1-ubuntu

  1. output-prefix
  2. Merge into britney1-ubuntu
Proposed by Colin Watson
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp:~cjwatson/britney/output-prefix
Merge into: lp:~ubuntu-release/britney/britney1-ubuntu
Diff against target: 48 lines (+13/-13)
1 file modified
britney (+13/-13)
To merge this branch: bzr merge lp:~cjwatson/britney/output-prefix
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+249048@code.launchpad.net

Commit message

If OUTPUT_PREFIX is set in the environment, prepend that to output file names.

Description of the change

If OUTPUT_PREFIX is set in the environment, prepend that to output file names.

This makes it possible to run multiple parallel instances for ubuntu-rtm in the short term, and also for Ubuntu stable series later on.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Would it perhaps be better to use a subdirectory for this, rather than a file prefix?

The code changes themselves look fine to me.

lp:~cjwatson/britney/output-prefix updated
274. By Colin Watson

Use subdirectory rather than file prefix.

Revision history for this message
Colin Watson (cjwatson) wrote :

Mm, that makes some sense. And then we can just put everything consistently in a subdirectory, and for URL compatibility have the top-level update_* be symlinks/redirects/whatever to the current series. Please re-review?

Revision history for this message
Steve Langasek (vorlon) wrote :

Would it perhaps be better to use a subdirectory for this, rather than a file prefix?

The code changes themselves look fine to me.

Revision history for this message
Steve Langasek (vorlon) wrote :

looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'britney'
--- britney 2014-12-10 14:55:57 +0000
+++ britney 2015-02-13 17:28:19 +0000
@@ -404,23 +404,23 @@
404404
405stats () {405stats () {
406 echo STATS:406 echo STATS:
407 mkdir -p "$HTML"407 mkdir -p "$HTML/$SERIES"
408 if [ "$1" = "b1" ]; then408 if [ "$1" = "b1" ]; then
409 cp $UPDATE_OUT/update.EXCUSES_py $HTML/update_excuses.html409 cp $UPDATE_OUT/update.EXCUSES_py $HTML/$SERIES/update_excuses.html
410 cp $UPDATE_OUT/update.OUTPUT_py $HTML/update_output.txt410 cp $UPDATE_OUT/update.OUTPUT_py $HTML/$SERIES/update_output.txt
411 else411 else
412 cp $DATA_B2/output/$SERIES/excuses.html $HTML/update_excuses.html412 cp $DATA_B2/output/$SERIES/excuses.html $HTML/$SERIES/update_excuses.html
413 cp $DATA_B2/output/$SERIES/excuses.yaml $HTML/update_excuses.yaml413 cp $DATA_B2/output/$SERIES/excuses.yaml $HTML/$SERIES/update_excuses.yaml
414 cp $DATA_B2/output/$SERIES/output.txt $HTML/update_output.txt414 cp $DATA_B2/output/$SERIES/output.txt $HTML/$SERIES/update_output.txt
415 cp $DATA_B2/$SERIES-proposed/Blocks $HTML/blocks.txt415 cp $DATA_B2/$SERIES-proposed/Blocks $HTML/$SERIES/blocks.txt
416 fi416 fi
417 #gzip -9 < $HTML/update_excuses.html > $HTML/update_excuses.html.gz417 #gzip -9 < $HTML/$SERIES/update_excuses.html > $HTML/$SERIES/update_excuses.html.gz
418 #gzip -9 < $HTML/update_output.txt > $HTML/update_output.txt.gz418 #gzip -9 < $HTML/$SERIES/update_output.txt > $HTML/$SERIES/update_output.txt.gz
419 mkdir -p "$HTML/update_output/$SERIES/${NOW%/*}"419 mkdir -p "$HTML/update_output/$SERIES/${NOW%/*}"
420 mkdir -p "$HTML/update_excuses/$SERIES/${NOW%/*}"420 mkdir -p "$HTML/update_excuses/$SERIES/${NOW%/*}"
421 gzip -9c $HTML/update_output.txt > $HTML/update_output/$SERIES/$NOW.txt.gz421 gzip -9c $HTML/$SERIES/update_output.txt > $HTML/update_output/$SERIES/$NOW.txt.gz
422 gzip -9c $HTML/update_excuses.html > $HTML/update_excuses/$SERIES/$NOW.html.gz422 gzip -9c $HTML/$SERIES/update_excuses.html > $HTML/update_excuses/$SERIES/$NOW.html.gz
423 gzip -9c $HTML/update_excuses.yaml > $HTML/update_excuses/$SERIES/$NOW.yaml.gz423 gzip -9c $HTML/$SERIES/update_excuses.yaml > $HTML/update_excuses/$SERIES/$NOW.yaml.gz
424424
425 # TODO: {stable,unstable}_uninst.txt -- needs support in b2, talk to Fabio425 # TODO: {stable,unstable}_uninst.txt -- needs support in b2, talk to Fabio
426 # TODO: this creates uninstallability reports against b2 results, not b1's426 # TODO: this creates uninstallability reports against b2 results, not b1's
@@ -434,7 +434,7 @@
434 #create_ood_report $DATA_B2/stable stable_outdate.txt434 #create_ood_report $DATA_B2/stable stable_outdate.txt
435 #create_ood_report $DATA_B2/testing testing_outdate.txt435 #create_ood_report $DATA_B2/testing testing_outdate.txt
436436
437 $SCRIPTS/backlog-report -o $HTML/update_excuses.csv $HTML/update_excuses.html437 $SCRIPTS/backlog-report -o $HTML/$SERIES/update_excuses.csv $HTML/$SERIES/update_excuses.html
438}438}
439439
440if option stats_b1; then440if option stats_b1; then

Subscribers

People subscribed via source and target branches