Merge lp:~cjwatson/launchpad/build-depends-arch into lp:launchpad

Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~cjwatson/launchpad/build-depends-arch
Merge into: lp:launchpad
Diff against target: 484 lines (+117/-26)
17 files modified
lib/lp/archivepublisher/indices.py (+2/-0)
lib/lp/archivepublisher/tests/test_indices.py (+9/-1)
lib/lp/archiveuploader/dscfile.py (+2/-0)
lib/lp/archiveuploader/tests/nascentupload.txt (+6/-0)
lib/lp/registry/browser/sourcepackage.py (+10/-0)
lib/lp/registry/interfaces/distroseries.py (+10/-7)
lib/lp/registry/model/distroseries.py (+6/-4)
lib/lp/registry/templates/sourcepackage-index.pt (+12/-0)
lib/lp/soyuz/doc/package-relationship.txt (+5/-1)
lib/lp/soyuz/doc/sourcepackagerelease.txt (+6/-4)
lib/lp/soyuz/interfaces/sourcepackagerelease.py (+11/-1)
lib/lp/soyuz/model/sourcepackagerelease.py (+2/-0)
lib/lp/soyuz/scripts/gina/handlers.py (+2/-0)
lib/lp/soyuz/scripts/gina/packages.py (+2/-0)
lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt (+23/-5)
lib/lp/soyuz/tests/test_publishing.py (+5/-2)
lib/lp/testing/factory.py (+4/-1)
To merge this branch: bzr merge lp:~cjwatson/launchpad/build-depends-arch
Reviewer Review Type Date Requested Status
Colin Watson (community) Disapprove
Review via email: mp+282345@code.launchpad.net

Commit message

Model and show SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch.

Description of the change

Model and show SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch. See https://code.launchpad.net/~cjwatson/launchpad/db-build-depends-arch/+merge/282344 for rationale.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :
review: Disapprove

Unmerged revisions

17889. By Colin Watson

Model and show SourcePackageRelease.builddependsarch and SourcePackageRelease.build_conflicts_arch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/archivepublisher/indices.py'
--- lib/lp/archivepublisher/indices.py 2014-10-31 13:28:31 +0000
+++ lib/lp/archivepublisher/indices.py 2016-01-12 17:05:26 +0000
@@ -118,8 +118,10 @@
118 fields.append('Maintainer', spr.dsc_maintainer_rfc822)118 fields.append('Maintainer', spr.dsc_maintainer_rfc822)
119 fields.append('Build-Depends', spr.builddepends)119 fields.append('Build-Depends', spr.builddepends)
120 fields.append('Build-Depends-Indep', spr.builddependsindep)120 fields.append('Build-Depends-Indep', spr.builddependsindep)
121 fields.append('Build-Depends-Arch', spr.builddependsarch)
121 fields.append('Build-Conflicts', spr.build_conflicts)122 fields.append('Build-Conflicts', spr.build_conflicts)
122 fields.append('Build-Conflicts-Indep', spr.build_conflicts_indep)123 fields.append('Build-Conflicts-Indep', spr.build_conflicts_indep)
124 fields.append('Build-Conflicts-Arch', spr.build_conflicts_arch)
123 fields.append('Architecture', spr.architecturehintlist)125 fields.append('Architecture', spr.architecturehintlist)
124 fields.append('Standards-Version', spr.dsc_standards_version)126 fields.append('Standards-Version', spr.dsc_standards_version)
125 fields.append('Format', spr.dsc_format)127 fields.append('Format', spr.dsc_format)
126128
=== modified file 'lib/lp/archivepublisher/tests/test_indices.py'
--- lib/lp/archivepublisher/tests/test_indices.py 2014-10-31 13:05:52 +0000
+++ lib/lp/archivepublisher/tests/test_indices.py 2016-01-12 17:05:26 +0000
@@ -64,7 +64,9 @@
64 """64 """
65 pub_source = self.getPubSource(65 pub_source = self.getPubSource(
66 builddepends='fooish', builddependsindep='pyfoo',66 builddepends='fooish', builddependsindep='pyfoo',
67 build_conflicts='bar', build_conflicts_indep='pybar')67 builddependsarch='libfoo-dev',
68 build_conflicts='bar', build_conflicts_indep='pybar',
69 build_conflicts_arch='libbar-dev')
6870
69 self.assertEqual(71 self.assertEqual(
70 [u'Package: foo',72 [u'Package: foo',
@@ -74,8 +76,10 @@
74 u'Maintainer: Foo Bar <foo@bar.com>',76 u'Maintainer: Foo Bar <foo@bar.com>',
75 u'Build-Depends: fooish',77 u'Build-Depends: fooish',
76 u'Build-Depends-Indep: pyfoo',78 u'Build-Depends-Indep: pyfoo',
79 u'Build-Depends-Arch: libfoo-dev',
77 u'Build-Conflicts: bar',80 u'Build-Conflicts: bar',
78 u'Build-Conflicts-Indep: pybar',81 u'Build-Conflicts-Indep: pybar',
82 u'Build-Conflicts-Arch: libbar-dev',
79 u'Architecture: all',83 u'Architecture: all',
80 u'Standards-Version: 3.6.2',84 u'Standards-Version: 3.6.2',
81 u'Format: 1.0',85 u'Format: 1.0',
@@ -99,7 +103,9 @@
99 """103 """
100 pub_source = self.getPubSource(104 pub_source = self.getPubSource(
101 builddepends='fooish', builddependsindep='pyfoo',105 builddepends='fooish', builddependsindep='pyfoo',
106 builddependsarch='libfoo-dev',
102 build_conflicts='bar', build_conflicts_indep='pybar',107 build_conflicts='bar', build_conflicts_indep='pybar',
108 build_conflicts_arch='libbar-dev',
103 user_defined_fields=[109 user_defined_fields=[
104 ("Python-Version", "< 1.5"),110 ("Python-Version", "< 1.5"),
105 ("CHECKSUMS-SHA1", "BLAH")])111 ("CHECKSUMS-SHA1", "BLAH")])
@@ -112,8 +118,10 @@
112 u'Maintainer: Foo Bar <foo@bar.com>',118 u'Maintainer: Foo Bar <foo@bar.com>',
113 u'Build-Depends: fooish',119 u'Build-Depends: fooish',
114 u'Build-Depends-Indep: pyfoo',120 u'Build-Depends-Indep: pyfoo',
121 u'Build-Depends-Arch: libfoo-dev',
115 u'Build-Conflicts: bar',122 u'Build-Conflicts: bar',
116 u'Build-Conflicts-Indep: pybar',123 u'Build-Conflicts-Indep: pybar',
124 u'Build-Conflicts-Arch: libbar-dev',
117 u'Architecture: all',125 u'Architecture: all',
118 u'Standards-Version: 3.6.2',126 u'Standards-Version: 3.6.2',
119 u'Format: 1.0',127 u'Format: 1.0',
120128
=== modified file 'lib/lp/archiveuploader/dscfile.py'
--- lib/lp/archiveuploader/dscfile.py 2015-07-30 07:46:08 +0000
+++ lib/lp/archiveuploader/dscfile.py 2016-01-12 17:05:26 +0000
@@ -661,8 +661,10 @@
661 maintainer=self.maintainer['person'],661 maintainer=self.maintainer['person'],
662 builddepends=encoded.get('Build-Depends', ''),662 builddepends=encoded.get('Build-Depends', ''),
663 builddependsindep=encoded.get('Build-Depends-Indep', ''),663 builddependsindep=encoded.get('Build-Depends-Indep', ''),
664 builddependsarch=encoded.get('Build-Depends-Arch', ''),
664 build_conflicts=encoded.get('Build-Conflicts', ''),665 build_conflicts=encoded.get('Build-Conflicts', ''),
665 build_conflicts_indep=encoded.get('Build-Conflicts-Indep', ''),666 build_conflicts_indep=encoded.get('Build-Conflicts-Indep', ''),
667 build_conflicts_arch=encoded.get('Build-Conflicts-Arch', ''),
666 architecturehintlist=encoded.get('Architecture', ''),668 architecturehintlist=encoded.get('Architecture', ''),
667 creator=self.changes.changed_by['person'],669 creator=self.changes.changed_by['person'],
668 urgency=self.changes.converted_urgency,670 urgency=self.changes.converted_urgency,
669671
=== modified file 'lib/lp/archiveuploader/tests/nascentupload.txt'
--- lib/lp/archiveuploader/tests/nascentupload.txt 2015-12-30 23:34:34 +0000
+++ lib/lp/archiveuploader/tests/nascentupload.txt 2016-01-12 17:05:26 +0000
@@ -373,12 +373,18 @@
373 >>> ed_spr.builddependsindep373 >>> ed_spr.builddependsindep
374 u''374 u''
375375
376 >>> ed_spr.builddependsarch
377 u''
378
376 >>> ed_spr.build_conflicts379 >>> ed_spr.build_conflicts
377 u'foo-bar'380 u'foo-bar'
378381
379 >>> ed_spr.build_conflicts_indep382 >>> ed_spr.build_conflicts_indep
380 u'biscuit'383 u'biscuit'
381384
385 >>> ed_spr.build_conflicts_arch
386 u''
387
382The content of 'debian/copyright' is stored as the 'copyright'388The content of 'debian/copyright' is stored as the 'copyright'
383attribute of SourcePackageRelease (note that its content is filtered389attribute of SourcePackageRelease (note that its content is filtered
384with encoding.guess()).390with encoding.guess()).
385391
=== modified file 'lib/lp/registry/browser/sourcepackage.py'
--- lib/lp/registry/browser/sourcepackage.py 2015-10-01 17:32:41 +0000
+++ lib/lp/registry/browser/sourcepackage.py 2016-01-12 17:05:26 +0000
@@ -520,6 +520,11 @@
520 self.context.currentrelease.builddependsindep)520 self.context.currentrelease.builddependsindep)
521521
522 @property522 @property
523 def builddependsarch(self):
524 return self._relationship_parser(
525 self.context.currentrelease.builddependsarch)
526
527 @property
523 def build_conflicts(self):528 def build_conflicts(self):
524 return self._relationship_parser(529 return self._relationship_parser(
525 self.context.currentrelease.build_conflicts)530 self.context.currentrelease.build_conflicts)
@@ -529,6 +534,11 @@
529 return self._relationship_parser(534 return self._relationship_parser(
530 self.context.currentrelease.build_conflicts_indep)535 self.context.currentrelease.build_conflicts_indep)
531536
537 @property
538 def build_conflicts_arch(self):
539 return self._relationship_parser(
540 self.context.currentrelease.build_conflicts_arch)
541
532 def requestCountry(self):542 def requestCountry(self):
533 return ICountry(self.request, None)543 return ICountry(self.request, None)
534544
535545
=== modified file 'lib/lp/registry/interfaces/distroseries.py'
--- lib/lp/registry/interfaces/distroseries.py 2015-10-13 13:22:08 +0000
+++ lib/lp/registry/interfaces/distroseries.py 2016-01-12 17:05:26 +0000
@@ -646,13 +646,13 @@
646646
647 def createUploadedSourcePackageRelease(647 def createUploadedSourcePackageRelease(
648 sourcepackagename, version, maintainer, builddepends,648 sourcepackagename, version, maintainer, builddepends,
649 builddependsindep, architecturehintlist, component, creator, urgency,649 builddependsindep, builddependsarch, architecturehintlist,
650 changelog, changelog_entry, dsc, dscsigningkey, section,650 component, creator, urgency, changelog, changelog_entry, dsc,
651 dsc_maintainer_rfc822, dsc_standards_version, dsc_format,651 dscsigningkey, section, dsc_maintainer_rfc822,
652 dsc_binaries, archive, copyright, build_conflicts,652 dsc_standards_version, dsc_format, dsc_binaries, archive, copyright,
653 build_conflicts_indep, dateuploaded=None,653 build_conflicts, build_conflicts_indep, build_conflicts_arch,
654 source_package_recipe_build=None, user_defined_fields=None,654 dateuploaded=None, source_package_recipe_build=None,
655 homepage=None):655 user_defined_fields=None, homepage=None):
656 """Create an uploads `SourcePackageRelease`.656 """Create an uploads `SourcePackageRelease`.
657657
658 Set this distroseries set to be the uploadeddistroseries.658 Set this distroseries set to be the uploadeddistroseries.
@@ -678,9 +678,12 @@
678 :param builddepends: string, DSC build dependencies678 :param builddepends: string, DSC build dependencies
679 :param builddependsindep: string, DSC architecture independent build679 :param builddependsindep: string, DSC architecture independent build
680 dependencies.680 dependencies.
681 :param builddependsarch: string, DSC architecture dependent build
682 dependencies.
681 :param build_conflicts: string, DSC Build-Conflicts content683 :param build_conflicts: string, DSC Build-Conflicts content
682 :param build_conflicts_indep: string, DSC Build-Conflicts-Indep684 :param build_conflicts_indep: string, DSC Build-Conflicts-Indep
683 content685 content
686 :param build_conflicts_arch: string, DSC Build-Conflicts-Arch content
684 :param dsc_maintainer_rfc822: string, DSC maintainer field687 :param dsc_maintainer_rfc822: string, DSC maintainer field
685 :param dsc_standards_version: string, DSC standards version field688 :param dsc_standards_version: string, DSC standards version field
686 :param dsc_format: string, DSC format version field689 :param dsc_format: string, DSC format version field
687690
=== modified file 'lib/lp/registry/model/distroseries.py'
--- lib/lp/registry/model/distroseries.py 2015-12-15 14:12:25 +0000
+++ lib/lp/registry/model/distroseries.py 2016-01-12 17:05:26 +0000
@@ -1142,11 +1142,11 @@
11421142
1143 def createUploadedSourcePackageRelease(1143 def createUploadedSourcePackageRelease(
1144 self, sourcepackagename, version, maintainer, builddepends,1144 self, sourcepackagename, version, maintainer, builddepends,
1145 builddependsindep, architecturehintlist, component, creator,1145 builddependsindep, builddependsarch, architecturehintlist, component,
1146 urgency, changelog, changelog_entry, dsc, dscsigningkey, section,1146 creator, urgency, changelog, changelog_entry, dsc, dscsigningkey,
1147 dsc_maintainer_rfc822, dsc_standards_version, dsc_format,1147 section, dsc_maintainer_rfc822, dsc_standards_version, dsc_format,
1148 dsc_binaries, archive, copyright, build_conflicts,1148 dsc_binaries, archive, copyright, build_conflicts,
1149 build_conflicts_indep, dateuploaded=DEFAULT,1149 build_conflicts_indep, build_conflicts_arch, dateuploaded=DEFAULT,
1150 source_package_recipe_build=None, user_defined_fields=None,1150 source_package_recipe_build=None, user_defined_fields=None,
1151 homepage=None):1151 homepage=None):
1152 """See `IDistroSeries`."""1152 """See `IDistroSeries`."""
@@ -1154,6 +1154,7 @@
1154 upload_distroseries=self, sourcepackagename=sourcepackagename,1154 upload_distroseries=self, sourcepackagename=sourcepackagename,
1155 version=version, maintainer=maintainer, dateuploaded=dateuploaded,1155 version=version, maintainer=maintainer, dateuploaded=dateuploaded,
1156 builddepends=builddepends, builddependsindep=builddependsindep,1156 builddepends=builddepends, builddependsindep=builddependsindep,
1157 builddependsarch=builddependsarch,
1157 architecturehintlist=architecturehintlist, component=component,1158 architecturehintlist=architecturehintlist, component=component,
1158 creator=creator, urgency=urgency, changelog=changelog,1159 creator=creator, urgency=urgency, changelog=changelog,
1159 changelog_entry=changelog_entry, dsc=dsc,1160 changelog_entry=changelog_entry, dsc=dsc,
@@ -1164,6 +1165,7 @@
1164 dsc_format=dsc_format, dsc_binaries=dsc_binaries,1165 dsc_format=dsc_format, dsc_binaries=dsc_binaries,
1165 build_conflicts=build_conflicts,1166 build_conflicts=build_conflicts,
1166 build_conflicts_indep=build_conflicts_indep,1167 build_conflicts_indep=build_conflicts_indep,
1168 build_conflicts_arch=build_conflicts_arch,
1167 source_package_recipe_build=source_package_recipe_build,1169 source_package_recipe_build=source_package_recipe_build,
1168 user_defined_fields=user_defined_fields, homepage=homepage)1170 user_defined_fields=user_defined_fields, homepage=homepage)
11691171
11701172
=== modified file 'lib/lp/registry/templates/sourcepackage-index.pt'
--- lib/lp/registry/templates/sourcepackage-index.pt 2015-11-24 01:44:28 +0000
+++ lib/lp/registry/templates/sourcepackage-index.pt 2016-01-12 17:05:26 +0000
@@ -124,6 +124,12 @@
124 <tal:block tal:condition="relationships/has_items"124 <tal:block tal:condition="relationships/has_items"
125 replace="structure relationships/@@+render-list"/>125 replace="structure relationships/@@+render-list"/>
126 </td>126 </td>
127 <td id="dependsarch"
128 tal:define="relationships view/builddependsarch">
129 <h3>Platform-dependent build dependencies</h3>
130 <tal:block tal:condition="relationships/has_items"
131 replace="structure relationships/@@+render-list"/>
132 </td>
127 </tr>133 </tr>
128 <tr>134 <tr>
129 <td id="conflicts" tal:define="relationships view/build_conflicts">135 <td id="conflicts" tal:define="relationships view/build_conflicts">
@@ -137,6 +143,12 @@
137 <tal:block tal:condition="relationships/has_items"143 <tal:block tal:condition="relationships/has_items"
138 replace="structure relationships/@@+render-list"/>144 replace="structure relationships/@@+render-list"/>
139 </td>145 </td>
146 <td id="conflictsarch"
147 tal:define="relationships view/build_conflicts_arch">
148 <h3>Platform-dependent build dependencies</h3>
149 <tal:block tal:condition="relationships/has_items"
150 replace="structure relationships/@@+render-list"/>
151 </td>
140 </tr>152 </tr>
141 </table>153 </table>
142 </div>154 </div>
143155
=== modified file 'lib/lp/soyuz/doc/package-relationship.txt'
--- lib/lp/soyuz/doc/package-relationship.txt 2015-07-29 16:55:28 +0000
+++ lib/lp/soyuz/doc/package-relationship.txt 2016-01-12 17:05:26 +0000
@@ -1,12 +1,16 @@
1= Package Relationship Model =1= Package Relationship Model =
22
3We call "package relationship" the DSC field which describes relation3We call "package relationship" the DSC field which describes relation
4between the package in question and others availble:4between the package in question and others available:
55
6For sources DSC provides:6For sources DSC provides:
77
8 * builddepends8 * builddepends
9 * builddependsindep9 * builddependsindep
10 * builddependsarch
11 * build_conflicts
12 * build_conflicts_indep
13 * build_conflicts_arch
1014
11For binaries we have:15For binaries we have:
1216
1317
=== modified file 'lib/lp/soyuz/doc/sourcepackagerelease.txt'
--- lib/lp/soyuz/doc/sourcepackagerelease.txt 2014-07-14 16:47:15 +0000
+++ lib/lp/soyuz/doc/sourcepackagerelease.txt 2016-01-12 17:05:26 +0000
@@ -143,6 +143,7 @@
143 >>> archhintlist = 'any'143 >>> archhintlist = 'any'
144 >>> builddepends = 'cdbs, debhelper (>= 4.1.0), libsysfs-dev, libhal-dev'144 >>> builddepends = 'cdbs, debhelper (>= 4.1.0), libsysfs-dev, libhal-dev'
145 >>> builddependsindep = ''145 >>> builddependsindep = ''
146 >>> builddependsarch = ''
146 >>> dsc_maintainer_rfc822 = 'Foo Bar <foo@bar.com>'147 >>> dsc_maintainer_rfc822 = 'Foo Bar <foo@bar.com>'
147 >>> dsc_standards_version = '2.6.1'148 >>> dsc_standards_version = '2.6.1'
148 >>> dsc_format = '1.0'149 >>> dsc_format = '1.0'
@@ -155,11 +156,12 @@
155156
156 >>> new_spr = hoary.createUploadedSourcePackageRelease(157 >>> new_spr = hoary.createUploadedSourcePackageRelease(
157 ... arg_name, version, arg_maintainer,158 ... arg_name, version, arg_maintainer,
158 ... builddepends, builddependsindep, archhintlist, arg_comp, arg_creator,159 ... builddepends, builddependsindep, builddependsarch, archhintlist,
159 ... arg_urgency, changelog, changelog_entry, dsc, arg_key, arg_sect,160 ... arg_comp, arg_creator, arg_urgency, changelog, changelog_entry, dsc,
160 ... dsc_maintainer_rfc822, dsc_standards_version, dsc_format,161 ... arg_key, arg_sect, dsc_maintainer_rfc822, dsc_standards_version,
161 ... dsc_binaries, archive, copyright=copyright,162 ... dsc_format, dsc_binaries, archive, copyright=copyright,
162 ... build_conflicts=None, build_conflicts_indep=None,163 ... build_conflicts=None, build_conflicts_indep=None,
164 ... build_conflicts_arch=None,
163 ... source_package_recipe_build=arg_recipebuild)165 ... source_package_recipe_build=arg_recipebuild)
164166
165 >>> new_spr.upload_distroseries.name167 >>> new_spr.upload_distroseries.name
166168
=== modified file 'lib/lp/soyuz/interfaces/sourcepackagerelease.py'
--- lib/lp/soyuz/interfaces/sourcepackagerelease.py 2015-09-28 17:38:45 +0000
+++ lib/lp/soyuz/interfaces/sourcepackagerelease.py 2016-01-12 17:05:26 +0000
@@ -50,10 +50,15 @@
50 "package depends to build"),50 "package depends to build"),
51 required=False)51 required=False)
52 builddependsindep = TextLine(52 builddependsindep = TextLine(
53 title=_("DSC build depends"),53 title=_("DSC arch-independent build depends"),
54 description=_("Same as builddepends, but the list is of "54 description=_("Same as builddepends, but the list is of "
55 "arch-independent packages"),55 "arch-independent packages"),
56 required=False)56 required=False)
57 builddependsarch = TextLine(
58 title=_("DSC arch-dependent build depends"),
59 description=_("Same as builddepends, but the list is of "
60 "arch-dependent packages"),
61 required=False)
57 build_conflicts = TextLine(62 build_conflicts = TextLine(
58 title=_("DSC build conflicts"),63 title=_("DSC build conflicts"),
59 description=_("Binaries that will conflict when building this "64 description=_("Binaries that will conflict when building this "
@@ -64,6 +69,11 @@
64 description=_("Same as build-conflicts but only lists "69 description=_("Same as build-conflicts but only lists "
65 "arch-independent binaries."),70 "arch-independent binaries."),
66 required=False)71 required=False)
72 build_conflicts_arch = TextLine(
73 title=_("DSC arch-dependent build conflicts"),
74 description=_("Same as build-conflicts but only lists "
75 "arch-dependent binaries."),
76 required=False)
67 architecturehintlist = TextLine(77 architecturehintlist = TextLine(
68 title=_("Architecture Hint List"),78 title=_("Architecture Hint List"),
69 description=_(79 description=_(
7080
=== modified file 'lib/lp/soyuz/model/sourcepackagerelease.py'
--- lib/lp/soyuz/model/sourcepackagerelease.py 2015-11-20 17:57:46 +0000
+++ lib/lp/soyuz/model/sourcepackagerelease.py 2016-01-12 17:05:26 +0000
@@ -99,8 +99,10 @@
99 changelog_entry = StringCol(dbName='changelog_entry')99 changelog_entry = StringCol(dbName='changelog_entry')
100 builddepends = StringCol(dbName='builddepends')100 builddepends = StringCol(dbName='builddepends')
101 builddependsindep = StringCol(dbName='builddependsindep')101 builddependsindep = StringCol(dbName='builddependsindep')
102 builddependsarch = StringCol(dbName='builddependsarch')
102 build_conflicts = StringCol(dbName='build_conflicts')103 build_conflicts = StringCol(dbName='build_conflicts')
103 build_conflicts_indep = StringCol(dbName='build_conflicts_indep')104 build_conflicts_indep = StringCol(dbName='build_conflicts_indep')
105 build_conflicts_arch = StringCol(dbName='build_conflicts_arch')
104 architecturehintlist = StringCol(dbName='architecturehintlist')106 architecturehintlist = StringCol(dbName='architecturehintlist')
105 homepage = StringCol(dbName='homepage')107 homepage = StringCol(dbName='homepage')
106 format = EnumCol(dbName='format', schema=SourcePackageType,108 format = EnumCol(dbName='format', schema=SourcePackageType,
107109
=== modified file 'lib/lp/soyuz/scripts/gina/handlers.py'
--- lib/lp/soyuz/scripts/gina/handlers.py 2015-05-20 11:31:11 +0000
+++ lib/lp/soyuz/scripts/gina/handlers.py 2016-01-12 17:05:26 +0000
@@ -624,8 +624,10 @@
624 changelog_entry=src.changelog_entry,624 changelog_entry=src.changelog_entry,
625 builddepends=src.build_depends,625 builddepends=src.build_depends,
626 builddependsindep=src.build_depends_indep,626 builddependsindep=src.build_depends_indep,
627 builddependsarch=src.build_depends_arch,
627 build_conflicts=src.build_conflicts,628 build_conflicts=src.build_conflicts,
628 build_conflicts_indep=src.build_conflicts_indep,629 build_conflicts_indep=src.build_conflicts_indep,
630 build_conflicts_arch=src.build_conflicts_arch,
629 architecturehintlist=src.architecture,631 architecturehintlist=src.architecture,
630 format=SourcePackageType.DPKG,632 format=SourcePackageType.DPKG,
631 upload_distroseries=distroseries.id,633 upload_distroseries=distroseries.id,
632634
=== modified file 'lib/lp/soyuz/scripts/gina/packages.py'
--- lib/lp/soyuz/scripts/gina/packages.py 2015-12-07 21:49:16 +0000
+++ lib/lp/soyuz/scripts/gina/packages.py 2016-01-12 17:05:26 +0000
@@ -277,8 +277,10 @@
277 # Defaults, potentially overwritten by __init__277 # Defaults, potentially overwritten by __init__
278 build_depends = ""278 build_depends = ""
279 build_depends_indep = ""279 build_depends_indep = ""
280 build_depends_arch = ""
280 build_conflicts = ""281 build_conflicts = ""
281 build_conflicts_indep = ""282 build_conflicts_indep = ""
283 build_conflicts_arch = ""
282 standards_version = ""284 standards_version = ""
283 section = None285 section = None
284 format = None286 format = None
285287
=== modified file 'lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt'
--- lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt 2015-11-30 04:18:39 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt 2016-01-12 17:05:26 +0000
@@ -118,12 +118,12 @@
118 ... 'http://launchpad.dev/ubuntu/breezy-autotest/+source/'118 ... 'http://launchpad.dev/ubuntu/breezy-autotest/+source/'
119 ... 'commercialpackage')119 ... 'commercialpackage')
120120
121PackageRelationships, 'builddepends', 'builddependsindep',121PackageRelationships, 'builddepends', 'builddependsindep', 'builddependsarch',
122'build_conflicts' and 'build_conflicts_indep' for the source in122'build_conflicts', 'build_conflicts_indep', and 'build_conflicts_arch' for the
123question are provided in this page.123source in question are provided in this page.
124124
125Even when the relationshipt section is empty they are presented,125Even when the relationship section is empty they are presented,
126keeping the page format contant.126keeping the page format constant.
127127
128 >>> depends_section = find_tag_by_id(browser.contents, 'depends')128 >>> depends_section = find_tag_by_id(browser.contents, 'depends')
129 >>> parse_relationship_section(str(depends_section))129 >>> parse_relationship_section(str(depends_section))
@@ -133,6 +133,10 @@
133 >>> parse_relationship_section(str(dependsindep_section))133 >>> parse_relationship_section(str(dependsindep_section))
134 EMPTY SECTION134 EMPTY SECTION
135135
136 >>> dependsarch_section = find_tag_by_id(browser.contents, 'dependsarch')
137 >>> parse_relationship_section(str(dependsarch_section))
138 EMPTY SECTION
139
136 >>> conflicts_section = find_tag_by_id(browser.contents, 'conflicts')140 >>> conflicts_section = find_tag_by_id(browser.contents, 'conflicts')
137 >>> parse_relationship_section(str(conflicts_section))141 >>> parse_relationship_section(str(conflicts_section))
138 EMPTY SECTION142 EMPTY SECTION
@@ -142,6 +146,11 @@
142 >>> parse_relationship_section(str(conflictsindep_section))146 >>> parse_relationship_section(str(conflictsindep_section))
143 EMPTY SECTION147 EMPTY SECTION
144148
149 >>> conflictsarch_section = find_tag_by_id(
150 ... browser.contents, 'conflictsarch')
151 >>> parse_relationship_section(str(conflictsarch_section))
152 EMPTY SECTION
153
145Let's inspect a page with non-empty relationships.154Let's inspect a page with non-empty relationships.
146155
147 >>> browser.open(156 >>> browser.open(
@@ -163,6 +172,10 @@
163 LINK: "pmount" -> http://launchpad.dev/ubuntu/warty/+package/pmount172 LINK: "pmount" -> http://launchpad.dev/ubuntu/warty/+package/pmount
164 TEXT: "postgresql-client (&gt;= 7.4)"173 TEXT: "postgresql-client (&gt;= 7.4)"
165174
175 >>> dependsarch_section = find_tag_by_id(browser.contents, 'dependsarch')
176 >>> parse_relationship_section(str(dependsarch_section))
177 EMPTY SECTION
178
166 >>> conflicts_section = find_tag_by_id(browser.contents, 'conflicts')179 >>> conflicts_section = find_tag_by_id(browser.contents, 'conflicts')
167 >>> parse_relationship_section(str(conflicts_section))180 >>> parse_relationship_section(str(conflicts_section))
168 TEXT: "gcc-4.0"181 TEXT: "gcc-4.0"
@@ -174,6 +187,11 @@
174 TEXT: "gcc-4.0-base"187 TEXT: "gcc-4.0-base"
175 LINK: "pmount" -> http://launchpad.dev/ubuntu/warty/+package/pmount188 LINK: "pmount" -> http://launchpad.dev/ubuntu/warty/+package/pmount
176189
190 >>> conflictsarch_section = find_tag_by_id(
191 ... browser.contents, 'conflictsarch')
192 >>> parse_relationship_section(str(conflictsarch_section))
193 EMPTY SECTION
194
177195
178The '+changelog' page provides an aggregation of the changelogs for196The '+changelog' page provides an aggregation of the changelogs for
179SourcePackageReleases published in this DistroSeries.197SourcePackageReleases published in this DistroSeries.
180198
=== modified file 'lib/lp/soyuz/tests/test_publishing.py'
--- lib/lp/soyuz/tests/test_publishing.py 2015-10-05 22:21:17 +0000
+++ lib/lp/soyuz/tests/test_publishing.py 2016-01-12 17:05:26 +0000
@@ -191,10 +191,11 @@
191 urgency=SourcePackageUrgency.LOW,191 urgency=SourcePackageUrgency.LOW,
192 scheduleddeletiondate=None, dateremoved=None,192 scheduleddeletiondate=None, dateremoved=None,
193 distroseries=None, archive=None, builddepends=None,193 distroseries=None, archive=None, builddepends=None,
194 builddependsindep=None, architecturehintlist='all',194 builddependsindep=None, builddependsarch=None,
195 architecturehintlist='all',
195 dsc_standards_version='3.6.2', dsc_format='1.0',196 dsc_standards_version='3.6.2', dsc_format='1.0',
196 dsc_binaries='foo-bin', build_conflicts=None,197 dsc_binaries='foo-bin', build_conflicts=None,
197 build_conflicts_indep=None,198 build_conflicts_indep=None, build_conflicts_arch=None,
198 dsc_maintainer_rfc822='Foo Bar <foo@bar.com>',199 dsc_maintainer_rfc822='Foo Bar <foo@bar.com>',
199 maintainer=None, creator=None, date_uploaded=UTC_NOW,200 maintainer=None, creator=None, date_uploaded=UTC_NOW,
200 spr_only=False, user_defined_fields=None):201 spr_only=False, user_defined_fields=None):
@@ -231,8 +232,10 @@
231 version=version,232 version=version,
232 builddepends=builddepends,233 builddepends=builddepends,
233 builddependsindep=builddependsindep,234 builddependsindep=builddependsindep,
235 builddependsarch=builddependsarch,
234 build_conflicts=build_conflicts,236 build_conflicts=build_conflicts,
235 build_conflicts_indep=build_conflicts_indep,237 build_conflicts_indep=build_conflicts_indep,
238 build_conflicts_arch=build_conflicts_arch,
236 architecturehintlist=architecturehintlist,239 architecturehintlist=architecturehintlist,
237 changelog=None,240 changelog=None,
238 changelog_entry=None,241 changelog_entry=None,
239242
=== modified file 'lib/lp/testing/factory.py'
--- lib/lp/testing/factory.py 2016-01-11 21:11:27 +0000
+++ lib/lp/testing/factory.py 2016-01-12 17:05:26 +0000
@@ -3575,9 +3575,10 @@
3575 creator=None, component=None,3575 creator=None, component=None,
3576 section_name=None, urgency=None,3576 section_name=None, urgency=None,
3577 version=None, builddepends=None,3577 version=None, builddepends=None,
3578 builddependsindep=None,3578 builddependsindep=None, builddependsarch=None,
3579 build_conflicts=None,3579 build_conflicts=None,
3580 build_conflicts_indep=None,3580 build_conflicts_indep=None,
3581 build_conflicts_arch=None,
3581 architecturehintlist='all',3582 architecturehintlist='all',
3582 dsc_maintainer_rfc822=None,3583 dsc_maintainer_rfc822=None,
3583 dsc_standards_version='3.6.2',3584 dsc_standards_version='3.6.2',
@@ -3643,8 +3644,10 @@
3643 version=version,3644 version=version,
3644 builddepends=builddepends,3645 builddepends=builddepends,
3645 builddependsindep=builddependsindep,3646 builddependsindep=builddependsindep,
3647 builddependsarch=builddependsarch,
3646 build_conflicts=build_conflicts,3648 build_conflicts=build_conflicts,
3647 build_conflicts_indep=build_conflicts_indep,3649 build_conflicts_indep=build_conflicts_indep,
3650 build_conflicts_arch=build_conflicts_arch,
3648 architecturehintlist=architecturehintlist,3651 architecturehintlist=architecturehintlist,
3649 changelog=changelog,3652 changelog=changelog,
3650 changelog_entry=changelog_entry,3653 changelog_entry=changelog_entry,