Launchpad itself

Merge lp:~cjwatson/launchpad/db-snap-build-record-code into lp:launchpad/db-devel

  1. db-snap-build-record-code
  2. Merge into db-devel
Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~cjwatson/launchpad/db-snap-build-record-code
Merge into: lp:launchpad/db-devel
Diff against target: 38 lines (+23/-0)
2 files modified
database/schema/patch-2210-02-0.sql (+22/-0)
lib/lp/code/doc/branch.txt (+1/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/db-snap-build-record-code
Reviewer Review Type Date Requested Status
Launchpad code reviewers db Pending
Review via email: mp+365355@code.launchpad.net

Commit message

Add SnapBuild.branch, SnapBuild.git_repository, SnapBuild.git_repository_url, and SnapBuild.git_path columns.

To post a comment you must log in.
lp:~cjwatson/launchpad/db-snap-build-record-code updated
14055. By Colin Watson

Register snapbuild.branch deletion requirement.

14056. By Colin Watson

Add SnapBuild.explicitly_private column.

Revision history for this message
Colin Watson (cjwatson) wrote :

Superseded by Thiago's work on project-based snap recipes with privacy controlled by the pillar.

Unmerged revisions

14056. By Colin Watson

Add SnapBuild.explicitly_private column.

14055. By Colin Watson

Register snapbuild.branch deletion requirement.

14054. By Colin Watson

Add SnapBuild.branch, SnapBuild.git_repository, SnapBuild.git_repository_url, and SnapBuild.git_path columns.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'database/schema/patch-2210-02-0.sql'
2--- database/schema/patch-2210-02-0.sql 1970-01-01 00:00:00 +0000
3+++ database/schema/patch-2210-02-0.sql 2019-05-24 16:17:42 +0000
4@@ -0,0 +1,22 @@
5+-- Copyright 2019 Canonical Ltd. This software is licensed under the
6+-- GNU Affero General Public License version 3 (see the file LICENSE).
7+
8+SET client_min_messages=ERROR;
9+
10+ALTER TABLE SnapBuild
11+ ADD COLUMN branch integer REFERENCES branch,
12+ ADD COLUMN git_repository integer REFERENCES gitrepository,
13+ ADD COLUMN git_repository_url text,
14+ ADD COLUMN git_path text,
15+ ADD COLUMN explicitly_private boolean;
16+
17+CREATE INDEX snapbuild__branch__idx ON SnapBuild(branch);
18+CREATE INDEX snapbuild__git_repository__idx ON SnapBuild(git_repository);
19+
20+COMMENT ON COLUMN SnapBuild.branch IS 'The Bazaar branch for this build.';
21+COMMENT ON COLUMN SnapBuild.git_repository IS 'The Git repository for this build.';
22+COMMENT ON COLUMN SnapBuild.git_repository_url IS 'The Git repository URL for this build.';
23+COMMENT ON COLUMN SnapBuild.git_path IS 'The Git branch path for this build.';
24+COMMENT ON COLUMN SnapBuild.explicitly_private IS 'Whether this build is private even if its snap and other associated resources are public.';
25+
26+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 02, 0);
27
28=== modified file 'lib/lp/code/doc/branch.txt'
29--- lib/lp/code/doc/branch.txt 2018-05-13 09:59:59 +0000
30+++ lib/lp/code/doc/branch.txt 2019-05-24 16:17:42 +0000
31@@ -400,6 +400,7 @@
32 productseries.translations_branch
33 seriessourcepackagebranch.branch
34 snap.branch
35+ snapbuild.branch
36 sourcepackagerecipedata.base_branch
37 sourcepackagerecipedatainstruction.branch
38 specificationbranch.branch

Subscribers

People subscribed via source and target branches

to status/vote changes: