Launchpad itself

Merge lp:~cjwatson/launchpad/db-snap-build-record-code into lp:launchpad/db-devel

  1. db-snap-build-record-code
  2. Merge into db-devel
Proposed by Colin Watson
Status: Rejected
Rejected by: Colin Watson
Proposed branch: lp:~cjwatson/launchpad/db-snap-build-record-code
Merge into: lp:launchpad/db-devel
Diff against target: 38 lines (+23/-0)
2 files modified
database/schema/patch-2210-02-0.sql (+22/-0)
lib/lp/code/doc/branch.txt (+1/-0)
To merge this branch: bzr merge lp:~cjwatson/launchpad/db-snap-build-record-code
Reviewer Review Type Date Requested Status
Launchpad code reviewers db Pending
Review via email: mp+365355@code.launchpad.net

Commit message

Add SnapBuild.branch, SnapBuild.git_repository, SnapBuild.git_repository_url, and SnapBuild.git_path columns.

To post a comment you must log in.
lp:~cjwatson/launchpad/db-snap-build-record-code updated
14055. By Colin Watson

Register snapbuild.branch deletion requirement.

14056. By Colin Watson

Add SnapBuild.explicitly_private column.

Revision history for this message
Colin Watson (cjwatson) wrote :

Superseded by Thiago's work on project-based snap recipes with privacy controlled by the pillar.

Unmerged revisions

14056. By Colin Watson

Add SnapBuild.explicitly_private column.

14055. By Colin Watson

Register snapbuild.branch deletion requirement.

14054. By Colin Watson

Add SnapBuild.branch, SnapBuild.git_repository, SnapBuild.git_repository_url, and SnapBuild.git_path columns.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'database/schema/patch-2210-02-0.sql'
--- database/schema/patch-2210-02-0.sql 1970-01-01 00:00:00 +0000
+++ database/schema/patch-2210-02-0.sql 2019-05-24 16:17:42 +0000
@@ -0,0 +1,22 @@
1-- Copyright 2019 Canonical Ltd. This software is licensed under the
2-- GNU Affero General Public License version 3 (see the file LICENSE).
3
4SET client_min_messages=ERROR;
5
6ALTER TABLE SnapBuild
7 ADD COLUMN branch integer REFERENCES branch,
8 ADD COLUMN git_repository integer REFERENCES gitrepository,
9 ADD COLUMN git_repository_url text,
10 ADD COLUMN git_path text,
11 ADD COLUMN explicitly_private boolean;
12
13CREATE INDEX snapbuild__branch__idx ON SnapBuild(branch);
14CREATE INDEX snapbuild__git_repository__idx ON SnapBuild(git_repository);
15
16COMMENT ON COLUMN SnapBuild.branch IS 'The Bazaar branch for this build.';
17COMMENT ON COLUMN SnapBuild.git_repository IS 'The Git repository for this build.';
18COMMENT ON COLUMN SnapBuild.git_repository_url IS 'The Git repository URL for this build.';
19COMMENT ON COLUMN SnapBuild.git_path IS 'The Git branch path for this build.';
20COMMENT ON COLUMN SnapBuild.explicitly_private IS 'Whether this build is private even if its snap and other associated resources are public.';
21
22INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 02, 0);
023
=== modified file 'lib/lp/code/doc/branch.txt'
--- lib/lp/code/doc/branch.txt 2018-05-13 09:59:59 +0000
+++ lib/lp/code/doc/branch.txt 2019-05-24 16:17:42 +0000
@@ -400,6 +400,7 @@
400 productseries.translations_branch400 productseries.translations_branch
401 seriessourcepackagebranch.branch401 seriessourcepackagebranch.branch
402 snap.branch402 snap.branch
403 snapbuild.branch
403 sourcepackagerecipedata.base_branch404 sourcepackagerecipedata.base_branch
404 sourcepackagerecipedatainstruction.branch405 sourcepackagerecipedatainstruction.branch
405 specificationbranch.branch406 specificationbranch.branch

Subscribers

People subscribed via source and target branches

to status/vote changes: