Code review comment for lp:~cjwatson/turnip/auto-create-repository

Revision history for this message
William Grant (wgrant) wrote :

On 14/02/15 20:34, Colin Watson wrote:
> It probably won't be *useful* in that case, but also not harmful; I
> mean, if we have to do something first to fork the repository, then
> we have to do that no matter what, right?

If we run into this case on production it must indicate a bug, and
rather than reporting a problem it will just silently do the wrong thing.

In what case would this be useful in a real environment? Also remember
that we currently have no local state except the repository, but that
will eventually change, at which point implicit creation on ENOENT
becomes less desirable.

I would have Launchpad's translatePath create the LP GitRepository and
then call into turnip to create the repo.

« Back to merge proposal