Merge lp:~cjwatson/ubuntu/precise/casper/jackd-debconf-hang into lp:ubuntu/precise/casper

Proposed by Colin Watson
Status: Merged
Merged at revision: 1004
Proposed branch: lp:~cjwatson/ubuntu/precise/casper/jackd-debconf-hang
Merge into: lp:ubuntu/precise/casper
Diff against target: 30 lines (+12/-0)
2 files modified
bin/casper-reconfigure (+3/-0)
debian/changelog (+9/-0)
To merge this branch: bzr merge lp:~cjwatson/ubuntu/precise/casper/jackd-debconf-hang
Reviewer Review Type Date Requested Status
Adam Conrad (community) Approve
Ubuntu branches Pending
Review via email: mp+98292@code.launchpad.net

Description of the change

casper-reconfigure fails when run within a ubiquity target-config hook because the environment is such that debconf thinks there's already an active frontend and so disregards the "-fnoninteractive" option to dpkg-reconfigure. Unsetting a few environment variables is enough to dispel this confusion.

To post a comment you must log in.
Revision history for this message
Adam Conrad (adconrad) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/casper-reconfigure'
--- bin/casper-reconfigure 2007-02-07 13:56:55 +0000
+++ bin/casper-reconfigure 2012-03-19 21:52:18 +0000
@@ -47,6 +47,9 @@
47 exit 047 exit 0
48fi48fi
4949
50unset DEBIAN_HAS_FRONTEND
51unset DEBIAN_FRONTEND
52unset DEBCONF_REDIR
50runcommandinroot "$root" dpkg-reconfigure -fnoninteractive --no-reload "$package"53runcommandinroot "$root" dpkg-reconfigure -fnoninteractive --no-reload "$package"
5154
52exit 055exit 0
5356
=== modified file 'debian/changelog'
--- debian/changelog 2012-03-15 11:57:27 +0000
+++ debian/changelog 2012-03-19 21:52:18 +0000
@@ -1,3 +1,12 @@
1casper (1.312) UNRELEASED; urgency=low
2
3 * bin/casper-reconfigure: Unset DEBIAN_HAS_FRONTEND, DEBIAN_FRONTEND, and
4 DEBCONF_REDIR so that casper-reconfigure properly uses the
5 noninteractive frontend when invoked from a ubiquity target-config hook
6 (LP: #955617).
7
8 -- Colin Watson <cjwatson@ubuntu.com> Mon, 19 Mar 2012 21:42:55 +0000
9
1casper (1.311) precise; urgency=low10casper (1.311) precise; urgency=low
211
3 * LightDM on kubuntu-active wants to start ubuntu.desktop,12 * LightDM on kubuntu-active wants to start ubuntu.desktop,

Subscribers

People subscribed via source and target branches

to all changes: