Code review comment for lp:~compiz-team/compiz/libcompizconfig-test-setup

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Revision 3212 works for me.

Though something like this:
64 + if (asprintf (&backenddir, "%s",
65 + override_backend) == -1)
66 + backenddir = NULL;

would be more clearly written:
    backenddir = strdup(override_backend);

However if you look at the surrounding code you will notice that any allocation and free of backenddir is pointless. Should just use override_backend in place.

review: Approve

« Back to merge proposal