Code review comment for lp:~cprov/launchpad/bug-430336-builder-status

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

This branch primarily replaces the HiddenBuilder hack used to
implicitly hides information about private sources with an more
appropriate and testable mechanism. Both BuilderSet:+index and
Builder:+index use the same template macro for rendering the builder
'status summary' now.

I could also remove `IBuilder.status` implementation entirely, since
it's not needed anymore. The dynamic form is much nicers (includes
icon and link to the building job). I thought it would be nicer to do
it in a separate branch, or at least, after the branch direction gets
approved.

I also took the opportunity to fix
https://bugs.edge.launchpad.net/bugs/430336, now IDLE builder in
manual-mode with state it clear in its 'status-summary'.

== Tests ==

./bin/test -vv -t builder-views.txt -t stories.ppa -t stories.soyuz

== Demo and Q/A ==

1. https://launchpad.dev/builders (log in as foo.bar)
2. 'Register a new build machine' and play with the 'builderok' and
   the 'manual' flag.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/builder-index.pt
  lib/lp/soyuz/stories/soyuz/xx-builder-page.txt
  lib/lp/soyuz/browser/tests/builder-views.txt
  lib/lp/soyuz/stories/soyuz/xx-private-builds.txt
  lib/lp/soyuz/templates/builders-index.pt
  lib/lp/soyuz/browser/builder.py
  lib/lp/soyuz/browser/configure.zcml
  lib/lp/soyuz/stories/soyuz/xx-buildfarm-index.txt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqyThYACgkQ7KBXuXyZSjBt0wCfegMiSBQgWbi9nbnwoIIc2mvC
SCoAnjXrfd2fkrF1Kw46FUiviRJ+Jwz7
=4ZHJ
-----END PGP SIGNATURE-----