Code review comment for lp:~cprov/launchpad/bug-432979-copy-archives

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

This branch fixes https://bugs.edge.launchpad.net/soyuz/+bug/432979 suppressing the 'upload-hint' section for non-PPA archives.

The assertion on the view should be kept since it's correct, i.e. the 'ppa_reference' should only be used with PPA archives.

This change is an RC in 3.0 (small and isolated enough and fixes on OOPS).

== Tests ==

./bin/test -vv -t xx-distribution-archives.txt

== Demo and Q/A ==

1. Create an COPY archive:

{{{
./scripts/populate-archive.py --from-suite hoary -s hoary -a 386 --to-archive test-1 --to-user cprov --reason 'yeah!'
}}}

2. Log in as <email address hidden>

3. Access https://launchpad.dev/ubuntu/+archive/test-1

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/archive-index.pt
  lib/lp/soyuz/stories/soyuz/xx-distribution-archives.txt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkq2E40ACgkQ7KBXuXyZSjCFhQCeMacB1VEFrjIKjHiRTSauBsF+
77oAoIbCrZPjw13SPksiXp0bqFpRULZx
=o/sH
-----END PGP SIGNATURE-----