Do

Code review comment for lp:~cszikszoy/do/config-MA-ext

Revision history for this message
Alex Launi (alexlauni) wrote :

Looks pretty good to me, just a couple of things I noticed
line 91 (of the diff) Gets an IEnumerable and then loops over it, you can probably do this whole thing with a single linq statement and then return the IEnumerable LINQ gives you. I think it'd be cleaner and possibly a small bit faster.

Also, this means we need to update the plugins, I'd like an approved plugins merge before we merge this one.

review: Needs Fixing

« Back to merge proposal