Do

Code review comment for lp:~cszikszoy/do/config-MA-ext

  1. config-MA-ext
  2. Merge into trunk
Revision history for this message
Alex Launi (alexlauni) wrote :

PluginManager.cs: ObjectsForAddin<T>, you made a string idName var; put it back the way it was, you only use it once there's no point in assigning it way ahead of time. Also, maybe we should define ExtensionPaths as a Dictionary, so that in the class we can refer to the paths with human names instead of hardcoding the paths in a bunch of places?

Other than that, looks good. +1

review: Approve

« Back to merge proposal