Code review comment for lp:~cyphermox/xscreensaver/update-to-5.14

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Hi Mathieu, I have not looked at your changes, but I just want to copy these notes that I sent to Jeremy who merged 5.13 and had planned to merge 5.14 :) Please verify that you have taken care of these.

"If you do the merge to Ubuntu again, I've noted these things:
- your changelog does not include the whole Ubuntu history
- your previous merge pulled debian 5.13-1 before it was released
 and we updated Standards-Version to 3.9.2 in it
 Just make sure it is not in the Ubuntu delta any longer
- the sequential slide-show patch is not mentioned in your changelog
- as I mentioned in your merge request, the memory leak patch is obsolete
- you have an extraneous debian/xscreensaver.desktop
New in 5.14-1:
- we've dropped the xli | xloadimage depends"

« Back to merge proposal